From dbb124ec76efcb2d553f4707ec2eec8bcfc1fdb7 Mon Sep 17 00:00:00 2001 From: Wataru Otsubo Date: Sun, 2 Feb 2025 03:05:00 +0900 Subject: [PATCH] refactor: rename single custom generator & update doc & remove unused fn def --- src/generator/codegen_register.rs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/generator/codegen_register.rs b/src/generator/codegen_register.rs index 6e06881..7eb2ed2 100644 --- a/src/generator/codegen_register.rs +++ b/src/generator/codegen_register.rs @@ -210,7 +210,7 @@ fn generate_field( /// /// - field is `bool` => [`generate_single_bool_field`] /// - field is `u8`/`u16`/`u32` => [`generate_single_ux_field`] -/// - field is custom [`Value`] => [`generate_custom_values_mask_enumdef`] & todo +/// - field is custom [`Value`] => [`generate_custom_values_mask_enumdef`] & [`generate_single_custom_values_field`] /// /// For the details of types of register/field, see [`DataType`]. /// Note that in both cases, mask definitions are the same. @@ -245,7 +245,7 @@ fn generate_single_field( } }, FieldType::CustomValue(values) => { - generate_custom_values_field(mask_name, snake_case_name, values) + generate_single_custom_values_field(mask_name, snake_case_name, values) } }; @@ -307,7 +307,7 @@ fn generate_single_ux_field( (code_getter, code_setter) } -fn custom_value_const_name(field_name: &Ident, value_name: &String) -> Ident { +fn custom_value_const_name(field_name: &Ident, value_name: &str) -> Ident { util::parse_to_ident(&format!( "{}_{}", field_name.to_string().to_shouty_snake_case(), @@ -348,7 +348,7 @@ fn generate_custom_values_mask_enumdef( } } -fn generate_custom_values_field( +fn generate_single_custom_values_field( mask_name: Ident, snake_case_name: Ident, values: &[Value], @@ -448,8 +448,6 @@ fn generate_multiple_field( (code_mask, code_getter, code_setter) } -fn generate_single_value_field() -> () {} - /// Generate bool "multiple" field definition (getter, setter). fn generate_multiple_bool_field( mask_name: Ident,