From c7247a366370ce40aabe080440f99fc4b788a7d7 Mon Sep 17 00:00:00 2001
From: Wataru Otsubo <wataru.otsubo@cern.ch>
Date: Sun, 3 Nov 2024 21:12:20 +0100
Subject: [PATCH] fix(versions): add version info in database

---
 CHANGELOG.md           | 4 ++++
 src/PSBoardDataBase.jl | 1 +
 src/import_data.jl     | 1 +
 3 files changed, 6 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 743e206..ecc56eb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - Exported notebooks are now deployed under notebooks url
 
+### Fixed
+
+- Converter version is filled during `create_database_from_exported_csvs`
+
 ## [0.2.0] - 2024-10-23
 
 - Julia v1.11 was released and v1.10 is new LTS
diff --git a/src/PSBoardDataBase.jl b/src/PSBoardDataBase.jl
index 71bec98..b050640 100644
--- a/src/PSBoardDataBase.jl
+++ b/src/PSBoardDataBase.jl
@@ -62,6 +62,7 @@ function create_database_from_exported_csvs(
     extra_100test_result_df = CSV.read(hundred_csv, DataFrame)
     jathubs_table = CSV.read(jathubs_csv, DataFrame)
 
+    insert_version_info(db)
     insert_qaqc_campaign_id(db)
     insert_qaqc_positions(db, jathubs_table)
 
diff --git a/src/import_data.jl b/src/import_data.jl
index e3647c3..1c55041 100644
--- a/src/import_data.jl
+++ b/src/import_data.jl
@@ -10,6 +10,7 @@ function insert_version_info(db::SQLite.DB)
         INSERT INTO versions VALUES (:converter)
         """,
     )
+    @info "converter version info" pkgversion(@__MODULE__) |> string
     DBInterface.execute(stmt, (; converter = pkgversion(@__MODULE__) |> string))
 
     nothing