Compare commits

...

4 commits
v2.0.0 ... main

Author SHA1 Message Date
a78416a18d fix: CHANGELOG diff links 2024-09-11 15:31:09 +09:00
2dd0c20ce4 update CHANGELOG 2024-09-11 15:25:50 +09:00
3fdbe5ad4c update: print error when no editor is specified & add-master-log doesn't
append csv file
2024-09-11 15:19:13 +09:00
4478ec1654 bump to v2.0.1
fix version in  Cargo.toml
2024-09-11 10:31:28 +09:00
4 changed files with 37 additions and 17 deletions

View file

@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
### Changed
- `add-master-log` now always create CSV file
- `convert-master-log` can still append to a CSV file
## [2.0.1]
### Fix
- version in Cargo.toml
## [2.0.0]
### Added
@ -43,8 +54,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Subcommand `add-master-log` to parse master log for shiftwork 0.1.0 and write out to CSV.
- Subcommand `check-db` to validate the database CSV file.
[Unreleased]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/main...v1.0.1
[2.0.0]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/v2.0.0...v1.1.0
[1.1.0]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/v1.1.0...v1.0.1
[1.0.1]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/v1.0.1...v1.0.0
[Unreleased]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/v1.0.1...main
[2.0.1]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/v2.0.0...v2.0.1
[2.0.0]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/v1.1.0...v2.0.0
[1.1.0]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/v1.0.1...v1.1.0
[1.0.1]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/compare/v1.0.0...v1.0.1
[1.0.0]: https://gitlab.cern.ch/wotsubo/psboard-qaqc-postprocess/-/tags/v1.0.0

2
Cargo.lock generated
View file

@ -730,7 +730,7 @@ dependencies = [
[[package]]
name = "psb-qaqc"
version = "1.1.0"
version = "2.0.1"
dependencies = [
"anyhow",
"assert_cmd",

View file

@ -1,6 +1,6 @@
[package]
name = "psb-qaqc"
version = "1.1.0"
version = "2.0.1"
edition = "2021"
[dependencies]

View file

@ -4,7 +4,7 @@ use std::{
fmt::Display,
fs::{self, File},
io::{self, BufRead, BufReader},
path::{self, Path, PathBuf},
path::{self, PathBuf},
str::FromStr,
};
@ -351,11 +351,12 @@ impl PsbQaqcResult {
// .collect_vec()
// }
fn write_psbqaqc_csv(result: MasterLogResult, outfile: PathBuf) -> Result<()> {
/// If `nonewfile` is `true`, out file is not created when there is already a file.
fn write_psbqaqc_csv(result: MasterLogResult, outfile: PathBuf, nonewfile: bool) -> Result<()> {
let expanded_results = PsbQaqcResult::from_masterlogresult(result);
let mut wtr = match outfile.exists() {
true => {
let mut wtr = match (outfile.exists(), nonewfile) {
(true, false) => {
let file = File::options()
.read(true)
.append(true)
@ -364,7 +365,7 @@ fn write_psbqaqc_csv(result: MasterLogResult, outfile: PathBuf) -> Result<()> {
.has_headers(false)
.from_writer(file)
}
false => {
(false, _) => {
println!("Creating new file: {}", outfile.display());
let file = File::options()
.create_new(true)
@ -374,6 +375,10 @@ fn write_psbqaqc_csv(result: MasterLogResult, outfile: PathBuf) -> Result<()> {
.has_headers(true)
.from_writer(file)
}
(true, true) => {
error!("Out file already exists but specified not to make new file");
return Err(anyhow!("Out file already exists"));
}
};
for result in expanded_results {
wtr.serialize(result)?;
@ -409,7 +414,7 @@ fn main() -> Result<()> {
let outfile = outfile.unwrap_or(get_output_filename(&result));
write_psbqaqc_csv(result, outfile.clone())?;
write_psbqaqc_csv(result, outfile.clone(), true)?;
println!("Add comments about errors in the last column of the CSV file");
println!("Press any key to start editting...");
@ -428,14 +433,17 @@ fn main() -> Result<()> {
editor
}
(None, Err(e1), Err(e2)) => {
info!("No VISUAL nor EDITOR found, {}, {}", e1, e2);
warn!("No VISUAL nor EDITOR found, {}, {}", e1, e2);
warn!("Using `nano` as a fallback editor");
"nano".to_string()
}
};
std::process::Command::new(editor)
.arg(outfile.clone())
.spawn()?
.wait()?;
.spawn()
.context("Error during spawning editor")?
.wait()
.context("Error while waiting editor")?;
{
let f = File::open(outfile.clone())?;
@ -444,7 +452,7 @@ fn main() -> Result<()> {
}
println!();
println!("Copy the CSV above and paste it to the database(Google sheets)");
println!("Choose Data->Split text to columns to format it");
println!("Choose `Data->Split text to columns` to format it");
println!("Press any key when upload finished...");
terminal::enable_raw_mode()?;
@ -483,7 +491,7 @@ fn main() -> Result<()> {
let outfile = outfile.unwrap_or(get_output_filename(&result));
write_psbqaqc_csv(result, outfile)?;
write_psbqaqc_csv(result, outfile, false)?;
}
Commands::CheckDB { csvfile } => {
// TODO: more friendly message (like row number)